[feature] Added organization filter to timeseries charts #532 #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandafy
force-pushed
the
radius-monitoring
branch
3 times, most recently
from
fdbb779
to
9b66c51
Compare
nemesifier
reviewed
Aug 29, 2023
There was a problem hiding this comment.
I see room for improvement here:
Instead of saying "organization filter", I think we should say something which indicates what we're currently viewing, I see these possible options:
- "All organizations" or "All available organizations" or "Organization: any"
- org.name or "Organization: org.name`
Or any other similar solution, what do you think?
1 task
pandafy
force-pushed
the
radius-monitoring
branch
from
2862039
to
9b7f01f
Compare
pandafy
force-pushed
the
radius-monitoring
branch
from
9b7f01f
to
213605d
Compare
pandafy
force-pushed
the
radius-monitoring
branch
from
bf4b1d5
to
ebe1d38
Compare
pandafy
force-pushed
the
radius-monitoring
branch
from
ebe1d38
to
418590d
Compare
nemesifier
reviewed
Mar 14, 2024
| @@ -671,6 +671,8 @@ def get_query( | |||
| params = self._get_query_params(time, start_date, end_date) | |||
| params.update(additional_params) | |||
| params.update({'start_date': start_date, 'end_date': end_date}) | |||
| if not params.get('organization_id') and self.config_dict.get('filter__all__'): | |||
There was a problem hiding this comment.
maybe we can use just __all__ for simplicity and clarity to anyone familiar with python (I think we use similar constructs elsewhere)?
| @@ -260,14 +260,14 @@ def get_list_query(self, query, precision='s'): | |||
| if not len(result.keys()) or result.keys()[0][1] is None: | |||
| return list(result.get_points()) | |||
| # Handles query which contains "GROUP BY TAG" clause | |||
| result_points = {} | |||
| result_points = OrderedDict() | |||
There was a problem hiding this comment.
AFAIK in recent versions of python dicts are ordered by default, isn't it?
pandafy
force-pushed
the
radius-monitoring
branch
from
08c5f7d
to
386c307
Compare
- Added option to define "summary_query" for metrics - Added functionality to handle "GROUP by tags" clause to InfluxDB client Related to #532
pandafy
force-pushed
the
radius-monitoring
branch
from
f0535a7
to
c00fe96
Compare
nemesifier
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #532