[fix] Updated with changes #576

Fixes #576

openwisp_monitoring/device/base/models.py

@@ -468,8 +468,6 @@ def handle_critical_metric(cls, instance, **kwargs):
  device_monitoring = cls.objects.get(device=instance.content_object)
  if not instance.is_active or kwargs.get('signal') == post_delete:
  device_monitoring.update_status('unknown')
- elif kwargs.get('signal') == post_save and instance.is_active:
- device_monitoring.update_status('ok')
  except cls.DoesNotExist:
  pass
 

openwisp_monitoring/device/tests/test_models.py

@@ -598,12 +598,12 @@ def test_disabling_critical_check(self):
  dm.refresh_from_db()
  self.assertEqual(dm.status, 'unknown')
  with self.subTest(
- "Ensure status doesn't change on saving active critical check"
+ 'Ensure status does not change on saving active critical check'
  ):
  ping_check_instance.is_active = True
  ping_check_instance.save()
  dm.refresh_from_db()
- self.assertEqual(dm.status, 'ok')
+ self.assertEqual(dm.status, 'unknown')
 
  def test_saving_non_critical_check(self):
  Check = load_model('check', 'Check')
@@ -621,7 +621,7 @@ def test_saving_non_critical_check(self):
  non_critical_check.is_active = False
  non_critical_check.save()
  self.assertEqual(
- handler.call_count, 0, "Signal should not be fired for non-critical check"
+ handler.call_count, 0, 'Signal should not be fired for non-critical check'
  )
  dm.refresh_from_db()
  self.assertEqual(dm.status, 'ok')