[feature] Added support for Dark Mode #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added initial dark mode functionality without including a separate logo for dark mode.
Implemented the use of awesometheme for logo management in the dark mode feature.
colthreepv
force-pushed
the
feat/dark-mode
branch
from
bc2e3df
to
903b61d
Compare
nemesifier
reviewed
Sep 25, 2024
There was a problem hiding this comment.
Thank you very much, Valerio!
I am going to push a few adjustments:
- Pygments Themes: The Pygments color formatting for code samples was not displaying well on the dark theme.
- Color Adjustment: I made the orange tone in the dark version slightly darker.
- Dark/Light Mode Switch: I have reinstated the dark/light mode switch in the upper right corner.
Here's how these changes look:
_templates/layout.html
Outdated
| {{ _('Dark') }} | ||
| </a> | ||
| </p> | ||
| </li> |
There was a problem hiding this comment.
There's a light/dark mode button built in the awesome sphinx theme, but I had disabled it, I am going to put it back (will just need to delete header.html and remove this.
_templates/layout.html
Outdated
| }); | ||
| }); | ||
| </script> | ||
| <!-- End Color Mode --> |
- Pygments Themes: The Pygments color formatting for code samples was not displaying well on the dark theme. - Color Adjustment: I made the orange tone in the dark version slightly darker. - Dark/Light Mode Switch: I have reinstated the dark/light mode switch in the upper right corner.
nemesifier
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
great work
preview:
