Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Attribute error when trying to get bounding box from a method field value #246
base: master
Are you sure you want to change the base?
[fix] Attribute error when trying to get bounding box from a method field value #246
Changes from 4 commits
58ec8d0
1d57899
191209b
0040739
84cd642
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is using
instance
instead ofgeo_value
intended?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, because in this case,
SerializerMethodField.to_representation
receives object instance instead of the actual geometry value.the problem was that
geo_value
initially stores the object instance (which doesn't provide.extent
attribute), so here we're making sure to actually get the geometry value instead of the object instance.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I don't understand then what's the purpose of calling
geo_value = method(instance)
, it seems like that line can be removed, sincegeo_value
is not used afterwards. Isn't it?But I am also not entirely convinced of the approach as explained above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it's not used afterwards, but what if -later- someone else needed to use it?
I believe
geo_value
should have the correct/actual GEO value, not aninstance
of the object.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand this. I don't want to introduce changes in a library that is used by thousands of developers lightly. Each change must be justified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nemesisdesign it's justified. did you try to reproduce this bug?
focus on the type of
geo_value
variable. it should hold a GEO value and not something else, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nemesisdesign if you're not convinced by my solution, then please try to reproduce the bug #247 and maybe suggest a proper fix?