mcast-snooping: Don't access ovs_list members directly.

The Clang analyzer has trouble tracking the pointer usage in mrouter_get_lru and will report a use after free incorrectly. This patch migrates to using standard ovs_list functions instead of directly accessing the next member, which suppresses clang's warning. Acked-by: Simon Horman <[email protected]> Signed-off-by: Mike Pattrick <[email protected]> Signed-off-by: Eelco Chaudron <[email protected]>
openvswitch · Sep 11, 2024 · ddd6490 · ddd6490
1 parent 363435f
commit ddd6490
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/mcast-snooping.c b/lib/mcast-snooping.c
@@ -653,7 +653,7 @@ mrouter_get_lru(const struct mcast_snooping *ms,
  OVS_REQ_RDLOCK(ms->rwlock)
 {
  if (!ovs_list_is_empty(&ms->mrouter_lru)) {
- *m = mcast_mrouter_from_lru_node(ms->mrouter_lru.next);
+ *m = mcast_mrouter_from_lru_node(ovs_list_front(&ms->mrouter_lru));
  return true;
  } else {
  *m = NULL;
@@ -726,7 +726,7 @@ mcast_snooping_port_get(const struct ovs_list *list,
  struct mcast_port_bundle **f)
 {
  if (!ovs_list_is_empty(list)) {
- *f = mcast_port_from_list_node(list->next);
+ *f = mcast_port_from_list_node(ovs_list_front(list));
  return true;
  } else {
  *f = NULL;