Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only show routes from current service week #1259

Open
wants to merge 15 commits into
base: dev
Choose a base branch
from

Conversation

miles-grant-ibigroup
Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup commented Aug 21, 2024

Description:
Makes use of new graphql parameters to limit route and nearby results to current week

  • routes
  • nearby

blocked waiting for otp-ui to be fixed

@miles-grant-ibigroup miles-grant-ibigroup self-assigned this Aug 21, 2024
@miles-grant-ibigroup miles-grant-ibigroup added the BLOCKED Blocked (waiting on another PR to be merged) label Sep 16, 2024
@miles-grant-ibigroup miles-grant-ibigroup removed the BLOCKED Blocked (waiting on another PR to be merged) label Sep 24, 2024
Copy link
Contributor

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to change the graphql queries

lib/actions/apiV2.js Outdated Show resolved Hide resolved
lib/actions/apiV2.js Outdated Show resolved Hide resolved
lib/components/viewers/nearby/stop.tsx Show resolved Hide resolved
@miles-grant-ibigroup
Copy link
Collaborator Author

@daniel-heppner-ibigroup to fix the graphql mocks

Copy link
Contributor

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be even better if we didn't rename the routes in the gql query

@@ -436,11 +438,15 @@ export const fetchNearby = (position, radius) => {
lon
code
gtfsId
stopRoutes: routes (serviceDates: $currentServiceWeek) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we renaming routes to stop routes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants