Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trolleybus GTFS type #6170

Open
wants to merge 4 commits into
base: dev-2.x
Choose a base branch
from

Conversation

miklcct
Copy link
Contributor

@miklcct miklcct commented Oct 17, 2024

Summary

Fix GTFS extended route types for trolleybus (8xx).

This replaces #6086 for trolleybuses only, and add tests for existing modes (except 200-299).

Issue

None yet

Unit tests

added for more existing modes

Documentation

None

@miklcct miklcct requested a review from a team as a code owner October 17, 2024 11:05
Copy link
Member

@optionsome optionsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone is using extended types between 800-899, this will change the output mode but I think they are quite rare. I would be ok with merging these changes.

@optionsome
Copy link
Member

@flaktack does this affect your deployments?

@flaktack
Copy link
Contributor

No, merging is fine with us.

@t2gran t2gran added this to the 2.7 (next release) milestone Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants