vector tile: add no-thru traffic restrictions layer #6146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaktack
force-pushed
the
feature/layer-groups
branch
from
24c6206
to
06f97dc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6146 +/- ##
=============================================
+ Coverage 69.92% 69.94% +0.01%
- Complexity 17722 17738 +16
=============================================
Files 1996 1996
Lines 75394 75467 +73
Branches 7713 7721 +8
=============================================
+ Hits 52720 52783 +63
- Misses 19997 20008 +11
+ Partials 2677 2676 -1 ☔ View full report in Codecov by Sentry. |
flaktack
force-pushed
the
feature/layer-groups
branch
2 times, most recently
from
1bb4fc1
to
b10b81d
Compare
+ group no-thru traffic and permission layers by mode
flaktack
force-pushed
the
feature/layer-groups
branch
from
b10b81d
to
336fb13
Compare
| @@ -181,9 +197,8 @@ private static List<StyleBuilder> edges(VectorSourceLayer edges) { | |||
| .group(EDGES_GROUP) | |||
| .typeLine() | |||
| .vectorSourceLayer(edges) | |||
| .lineColor(MAGENTA) | |||
| .edgeFilter(EDGES_TO_DISPLAY) | |||
There was a problem hiding this comment.
Can you explain why we remove this filter?
| .toList(); | ||
| } | ||
|
|
||
| private static String permissionColors(StreetTraversalPermission p) { |
There was a problem hiding this comment.
Suggested change
| private static String permissionColors(StreetTraversalPermission p) { | |
| private static String permissionColor(StreetTraversalPermission p) { |
| .lineColor(MAGENTA) | ||
| .edgeFilter(EDGES_TO_DISPLAY) | ||
| .lineWidth(LINE_WIDTH) | ||
| .lineColor(GRAY) |
There was a problem hiding this comment.
This is hard to see.
Comment on lines
+220
to
+221
| .lineColor(GRAY) | ||
| .lineOpacity(0.2f) |
There was a problem hiding this comment.
This is very hard to see
| public static String streetPermissionAsString(StreetTraversalPermission permission) { | ||
| return ( | ||
| permission == StreetTraversalPermission.ALL | ||
| ? "PEDESTRIAN_AND_BICYCLE_AND_CAR" |
There was a problem hiding this comment.
This does add a bit of noise to the map since the labels that used to say ALL now says PEDESTRIAN BICYCLE CAR. Maybe that's ok since it's more explicit?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The new vector tile layers did not include no-thru traffic details. This adds layers reusing the existing colors from the permission layer.
The edge layers are grouped by street mode. This allows coloring all edges usable by the selected modes.
Issue
Fixes #6145