Use OpenTelemetry Shim with Lightstep launcher #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 4, 2020 20:44
Signed-off-by: Sergei Malafeev <[email protected]>
Signed-off-by: Sergei Malafeev <[email protected]>
| tracer = new JRETracer(opts); | ||
| OpenTelemetryConfiguration.newBuilder() | ||
| .setServiceName(componentName) | ||
| .setAccessToken(config.getProperty("lightstep.access_token")) |
There was a problem hiding this comment.
It would be nice to directly use the new system property names, e.g. ls.acess.token (as also, in the future, we want to support configuration through property files).
There was a problem hiding this comment.
updated to use system properties
microdonuts/pom.xml
Outdated
| <version>0.14.2</version> | ||
| <groupId>io.opentelemetry</groupId> | ||
| <artifactId>opentelemetry-opentracing-shim</artifactId> | ||
| <version>0.7.0-20200727.220734-33</version> |
There was a problem hiding this comment.
Is this version still accessible/download-able? Else, we should probably wait for the 0.7.0 release of the agent (and related components).
There was a problem hiding this comment.
yes, it's better to wait for 0.7.0.
added 2 commits
August 4, 2020 22:58
Signed-off-by: Sergei Malafeev <[email protected]>
Signed-off-by: Sergei Malafeev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @carlosalberto