Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor search feature #84

Merged
merged 12 commits into from
Sep 2, 2024
Merged

Refactor search feature #84

merged 12 commits into from
Sep 2, 2024

Conversation

damianstasik
Copy link
Collaborator

@damianstasik damianstasik commented Aug 26, 2024 •
edited by Yantrio
Loading

TODO:

  • Use generated types once they are ready
  • Make sure correct titles are used (backend changes required)
  • Finish UI for all search type results
  • Integrate the search feature on home page
  • Hide the search bar in the header while being on the home page

Fixes #81, #59 and #48

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Aug 26, 2024 •
edited
Loading

Deploying registry-ui with  Cloudflare Pages  Cloudflare Pages

Latest commit: ead3446
Status: ✅  Deploy successful!
Preview URL: https://b796b332.registry-ui-dxi.pages.dev
Branch Preview URL: https://refactor-search.registry-ui-dxi.pages.dev

View logs

@damianstasik damianstasik mentioned this pull request Aug 26, 2024
Closed
@damianstasik damianstasik force-pushed the refactor-search branch 4 times, most recently from 2a50a58 to 60c50f8 Compare August 30, 2024 12:09
@Yantrio Yantrio marked this pull request as ready for review September 2, 2024 13:18
damianstasik and others added 9 commits September 2, 2024 14:29
@damianstasik @Yantrio
Refactor search feature
dc6d559 
Signed-off-by: Damian Stasik <[email protected]>
@damianstasik @Yantrio
Support provider docs
6a9b197 
Signed-off-by: Damian Stasik <[email protected]>
@damianstasik @Yantrio
Use final API url
39aa1d0 
Signed-off-by: Damian Stasik <[email protected]>
@damianstasik @Yantrio
Use generated types
46eb138 
Signed-off-by: Damian Stasik <[email protected]>
@Yantrio
Handle generating titles clientside for now
52513fe 
Signed-off-by: James Humphries <[email protected]>
@Yantrio
handle case where no results are being shown
94fabce 
Signed-off-by: James Humphries <[email protected]>
@Yantrio
Hide search on main page
045cde8 
Signed-off-by: James Humphries <[email protected]>
@Yantrio
Added small bar option
07c1a9e 
Signed-off-by: James Humphries <[email protected]>
@Yantrio
fix search issues
9192da3 
Signed-off-by: James Humphries <[email protected]>
damianstasik
damianstasik commented Sep 2, 2024
View reviewed changes
frontend/src/q.ts Outdated Show resolved Hide resolved
@Yantrio
just await json in q
550c13b 
Signed-off-by: James Humphries <[email protected]>
@Yantrio
switch away from defaultprops
c5e6029 
Signed-off-by: James Humphries <[email protected]>
@Yantrio
moved in new default values for search
ead3446 
Signed-off-by: James Humphries <[email protected]>
RLRabinowitz
RLRabinowitz reviewed Sep 2, 2024
View reviewed changes
Copy link

@RLRabinowitz RLRabinowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall

frontend/src/q.ts Show resolved Hide resolved
@Yantrio Yantrio merged commit bbc7b01 into main Sep 2, 2024
4 checks passed
@Yantrio Yantrio deleted the refactor-search branch September 2, 2024 16:23
This was referenced Sep 2, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yantrio Yantrio Yantrio left review comments

@RLRabinowitz RLRabinowitz RLRabinowitz approved these changes

@Evi1Pumpkin Evi1Pumpkin Awaiting requested review from Evi1Pumpkin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dash - crashes the search
3 participants
@damianstasik @Yantrio @RLRabinowitz