-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor search feature #84
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying registry-ui with Cloudflare Pages
|
damianstasik
force-pushed
the
refactor-search
branch
4 times, most recently
from
August 30, 2024 12:09
2a50a58
to
60c50f8
Compare
Yantrio
force-pushed
the
refactor-search
branch
from
September 2, 2024 13:17
b2f3359
to
2744639
Compare
Signed-off-by: Damian Stasik <[email protected]>
Signed-off-by: Damian Stasik <[email protected]>
Signed-off-by: Damian Stasik <[email protected]>
Signed-off-by: Damian Stasik <[email protected]>
Signed-off-by: James Humphries <[email protected]>
Signed-off-by: James Humphries <[email protected]>
Signed-off-by: James Humphries <[email protected]>
Signed-off-by: James Humphries <[email protected]>
Signed-off-by: James Humphries <[email protected]>
Yantrio
force-pushed
the
refactor-search
branch
from
September 2, 2024 14:05
2744639
to
9192da3
Compare
damianstasik
commented
Sep 2, 2024
damianstasik
commented
Sep 2, 2024
Signed-off-by: James Humphries <[email protected]>
Signed-off-by: James Humphries <[email protected]>
Signed-off-by: James Humphries <[email protected]>
RLRabinowitz
reviewed
Sep 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall
RLRabinowitz
approved these changes
Sep 2, 2024
This was referenced Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Fixes #81, #59 and #48