Improve error handling in the UI #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Damian Stasik <[email protected]>
damianstasik
force-pushed
the
improve-error-handling
branch
from
4f52208
to
e435780
Compare
Deploying registry-ui with
|
| Latest commit: |
d2dd7b3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://431033ee.registry-ui-dxi.pages.dev |
| Branch Preview URL: | https://improve-error-handling.registry-ui-dxi.pages.dev |
Signed-off-by: Damian Stasik <[email protected]>
Yantrio
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96
I've used a small wrapper (
ky) aroundfetchto unify HTTP response error handling. Whenever we receive a non-200 HTTP response, it throws anHTTPErrorthat is caught by the error boundary around the routes. We can still display the 404 page by throwing aNotFoundPageError, for example, when requesting a non-existent submodule within an existing module's data.I've also moved all routes under a route layout to use a single error boundary – I recommend disabling whitespace changes on the diff view.