Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[thread-host] add get channel mask #2553

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

Irving-cl
Copy link
Contributor

This PR adds the GetChannelMask method to ThreadHost.

The PR implements this method for RcpHost. The implementation for NCP will be added later.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 45.65%. Comparing base (2b41187) to head (91ba773).
Report is 837 commits behind head on main.

Files with missing lines Patch % Lines
src/ncp/rcp_host.cpp 0.00% 11 Missing ⚠️
src/ncp/ncp_host.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2553       +/-   ##
===========================================
- Coverage   55.77%   45.65%   -10.13%     
===========================================
  Files          87      102       +15     
  Lines        6890    12222     +5332     
  Branches        0      895      +895     
===========================================
+ Hits         3843     5580     +1737     
- Misses       3047     6343     +3296     
- Partials        0      299      +299     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/ncp/thread_host.hpp Outdated Show resolved Hide resolved
src/ncp/thread_host.hpp Outdated Show resolved Hide resolved
@Irving-cl Irving-cl force-pushed the thread_host_get_channel_mask branch 2 times, most recently from cd783ff to af9c8a5 Compare October 22, 2024 02:36
Copy link
Contributor

@zhanglongxia zhanglongxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Irving-cl Irving-cl requested a review from jwhui October 22, 2024 15:15
@jwhui jwhui changed the title [thread host] add get channel mask [thread-host] add get channel mask Oct 23, 2024
@jwhui jwhui merged commit 85b8c97 into openthread:main Oct 23, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants