Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infra if] add infra if icmp6 nd receiving #2547

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Irving-cl
Copy link
Contributor

This PR implements Icmp6Nd receiving in the InfraIf module.

The method is used to receive ICMPv6 ND messages (on host) and forward them to the NCP. The implementation of this method is the same as OT posix implementation. In this PR, the forwarding to NCP hasn't been implemented. It will be later integrated with NcpSpinel.

This PR also adds a test case to verify that HandleIcmp6Nd is called correctly when the infrastructure interface receives an ICMP6 ND message.

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 75.86207% with 21 lines in your changes missing coverage. Please review.

Project coverage is 45.68%. Comparing base (2b41187) to head (c0469e8).
Report is 835 commits behind head on main.

Files with missing lines Patch % Lines
src/ncp/posix/infra_if.cpp 71.42% 10 Missing and 2 partials ⚠️
tests/gtest/test_infra_if.cpp 80.00% 8 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2547       +/-   ##
===========================================
- Coverage   55.77%   45.68%   -10.10%     
===========================================
  Files          87      102       +15     
  Lines        6890    12296     +5406     
  Branches        0      900      +900     
===========================================
+ Hits         3843     5617     +1774     
- Misses       3047     6374     +3327     
- Partials        0      305      +305     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/ncp/posix/infra_if.cpp Outdated Show resolved Hide resolved
src/ncp/posix/infra_if.cpp Outdated Show resolved Hide resolved
src/ncp/posix/infra_if.cpp Show resolved Hide resolved
src/ncp/posix/infra_if.cpp Outdated Show resolved Hide resolved
Copy link
Member

@abtink abtink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

src/ncp/posix/infra_if.cpp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants