[utils] generic vendor server #1995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d#1967)" (openthread#1995) This reverts commit 300cfed. Change-Id: Ic8694b97ddb4125599314769361ea10d483b01cc
wgtdkp
added a commit
to wgtdkp/ot-br-posix
that referenced
this pull request
Sep 4, 2023
This commit changes VendorServer to an abstract class so that it can be extended to have different implementations. Fulfills request from openthread#1967 (comment) Change-Id: Ic322efbee9b58d7a2743c72a511572ec7ebfb262
wgtdkp
force-pushed
the
generic-vendor-server
branch
from
f169587
to
76837f7
Compare
wgtdkp
added a commit
to wgtdkp/ot-br-posix
that referenced
this pull request
Sep 4, 2023
This commit changes VendorServer to an abstract class so that it can be extended to have different implementations. Fulfills request from openthread#1967 (comment) Change-Id: Ic322efbee9b58d7a2743c72a511572ec7ebfb262
wgtdkp
force-pushed
the
generic-vendor-server
branch
from
76837f7
to
6a9488b
Compare
wgtdkp
added a commit
to wgtdkp/ot-br-posix
that referenced
this pull request
Sep 4, 2023
This commit changes VendorServer to an abstract class so that it can be extended to have different implementations. Fulfills request from openthread#1967 (comment)
wgtdkp
force-pushed
the
generic-vendor-server
branch
from
6a9488b
to
19232c5
Compare
wgtdkp
added a commit
to wgtdkp/ot-br-posix
that referenced
this pull request
Sep 4, 2023
This commit changes VendorServer to an abstract class so that it can be extended to have different implementations. Fulfills request from openthread#1967 (comment)
wgtdkp
force-pushed
the
generic-vendor-server
branch
from
19232c5
to
c0e3774
Compare
|
This looks good to me, thanks for considering this! |
wgtdkp
added a commit
to wgtdkp/ot-br-posix
that referenced
this pull request
Sep 5, 2023
This commit changes VendorServer to an abstract class so that it can be extended to have different implementations. Fulfills request from openthread#1967 (comment)
wgtdkp
force-pushed
the
generic-vendor-server
branch
from
c0e3774
to
666cbcb
Compare
wgtdkp
added a commit
to wgtdkp/ot-br-posix
that referenced
this pull request
Sep 5, 2023
This commit changes VendorServer to an abstract class so that it can be extended to have different implementations. Fulfills request from openthread#1967 (comment)
wgtdkp
force-pushed
the
generic-vendor-server
branch
from
666cbcb
to
fd72331
Compare
|
@jwhui prefer merging this PR as separate commits |
jwhui
reviewed
Sep 5, 2023
This commit changes VendorServer to an abstract class so that it can be extended to have different implementations. Fulfills request from openthread#1967 (comment) Change-Id: Ic1b41b8b60e5953142854f761e377e080f1937fc
wgtdkp
force-pushed
the
generic-vendor-server
branch
from
fd72331
to
b38ff23
Compare
jwhui
approved these changes
Sep 6, 2023
jwhui
pushed a commit
that referenced
this pull request
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR include two commits:
Prefer merging this PR as separate commits