Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Adds authn time skew config #1175

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Conversation

dmihalcik-virtru
Copy link
Member

  • Adds acceptable skew control to oidc configuration
    • for idp provided tokens, use skew (default 1 minute)
    • for client provided tokens (dpop tokens), use dpopskew (default 1 hour)
  • This should reduce flakiness on some tests

- Adds acceptable skew control to oidc configuration
  - for idp provided tokens, use `skew` (default 1 minute)
  - for client provided tokens (dpop tokens), use `dpopskew` (default 1 hour)
- This should reduce flakiness on some tests
@dmihalcik-virtru dmihalcik-virtru changed the title feat(core): Adds authn skew config feat(core): Adds authn time skew config Jul 18, 2024
@dmihalcik-virtru dmihalcik-virtru marked this pull request as ready for review July 19, 2024 15:33
@dmihalcik-virtru dmihalcik-virtru requested a review from a team as a code owner July 19, 2024 15:33
@dmihalcik-virtru dmihalcik-virtru added this pull request to the merge queue Jul 19, 2024
Merged via the queue into main with commit adde7c4 Jul 19, 2024
17 checks passed
@dmihalcik-virtru dmihalcik-virtru deleted the feature/skew-minute branch July 19, 2024 16:07
github-merge-queue bot pushed a commit that referenced this pull request Jul 22, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.4.13](service/v0.4.12...service/v0.4.13)
(2024-07-22)


### Features

* **core:** Adds authn time skew config
([#1175](#1175))
([adde7c4](adde7c4))


### Bug Fixes

* **core:** Autobump service
([#1192](#1192))
([dbae4ff](dbae4ff))
* fixed policy binding type
([#1184](#1184))
([9800a32](9800a32))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants