Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPRUN-3576: Add OLMv1 origin tests #29189

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tmshort
Copy link

@tmshort tmshort commented Oct 14, 2024

This is the initial test. Only works on tech-preview. Checks for presence of OLMv1 CRDs.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 14, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 14, 2024

@tmshort: This pull request references OPRUN-3576 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

This is the initial test. Only works on tech-preview. Checks for presence of OLMv1 CRDs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Oct 14, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 14, 2024
Copy link
Contributor

openshift-ci bot commented Oct 14, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tmshort
Once this PR has been reviewed and has the lgtm label, please assign neisw for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tmshort tmshort marked this pull request as ready for review October 14, 2024 19:27
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 14, 2024
This is the initial test. Only works on tech-preview.
Checks for presence of OLMv1 CRDs.

Signed-off-by: Todd Short <[email protected]>
@tmshort
Copy link
Author

tmshort commented Oct 16, 2024

/retest

1 similar comment
@tmshort
Copy link
Author

tmshort commented Oct 17, 2024

/retest

@tmshort
Copy link
Author

tmshort commented Oct 17, 2024

Since you were lucky enough to be randomly chosen by github... @deads2k @mike-nguyen, my tests only do something under tech-preview (until OLMv1 is out of tech preview), but a number prow jobs seem to be failing? Is this normal? How do I get this PR to progress?

@LalatenduMohanty
Copy link
Member

@wking @petr-muller are my go to origin test experts. Can you guys take a look?

Copy link
Contributor

openshift-ci bot commented Oct 17, 2024

@tmshort: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-ipsec-serial f15e4ed link false /test e2e-aws-ovn-ipsec-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: f15e4ed

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn High
[sig-api-machinery] disruption/cache-kube-api connection/new should be available throughout the test
This test has passed 99.77% of 5687 runs on release 4.18 [Overall] in the last week.
---
[sig-api-machinery] disruption/openshift-api connection/new should be available throughout the test
This test has passed 99.86% of 5687 runs on release 4.18 [Overall] in the last week.
---
[sig-api-machinery] disruption/kube-api connection/new should be available throughout the test
This test has passed 99.75% of 5687 runs on release 4.18 [Overall] in the last week.
---
[sig-api-machinery] disruption/cache-oauth-api connection/new should be available throughout the test
This test has passed 99.86% of 5687 runs on release 4.18 [Overall] in the last week.

@tmshort
Copy link
Author

tmshort commented Oct 17, 2024

/retest

@dgoodwin
Copy link
Contributor

/override ci/prow/e2e-aws-ovn-ipsec-serial

Known broken.

Copy link
Contributor

openshift-ci bot commented Oct 17, 2024

@dgoodwin: Overrode contexts on behalf of dgoodwin: ci/prow/e2e-aws-ovn-ipsec-serial

In response to this:

/override ci/prow/e2e-aws-ovn-ipsec-serial

Known broken.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a reasonable foray into OLMv1 origin tests, but I do wonder if this will really stand the test of time.

I would somewhat assume that this would be quickly obviated by origin tests that actually exercise the APIs that we expect to exist.

var err error
var raw string
for _, ver := range api.version {
raw, err = oc.AsAdmin().Run("get").Args("crds", fmt.Sprintf("%s.%s", api.plural, api.group), fmt.Sprintf("-o=jsonpath={.spec.versions[?(@.name==\"%s\")]}", ver)).Output()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: to avoid having to use escaped quotation marks

Suggested change
raw, err = oc.AsAdmin().Run("get").Args("crds", fmt.Sprintf("%s.%s", api.plural, api.group), fmt.Sprintf("-o=jsonpath={.spec.versions[?(@.name==\"%s\")]}", ver)).Output()
raw, err = oc.AsAdmin().Run("get").Args("crds", fmt.Sprintf("%s.%s", api.plural, api.group), fmt.Sprintf(`-o=jsonpath={.spec.versions[?(@.name==%q)]}`, ver)).Output()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants