-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OPRUN-3576: Add OLMv1 origin tests #29189
base: master
Are you sure you want to change the base?
Conversation
@tmshort: This pull request references OPRUN-3576 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tmshort The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is the initial test. Only works on tech-preview. Checks for presence of OLMv1 CRDs. Signed-off-by: Todd Short <[email protected]>
/retest |
1 similar comment
/retest |
Since you were lucky enough to be randomly chosen by github... @deads2k @mike-nguyen, my tests only do something under tech-preview (until OLMv1 is out of tech preview), but a number prow jobs seem to be failing? Is this normal? How do I get this PR to progress? |
@wking @petr-muller are my go to origin test experts. Can you guys take a look? |
@tmshort: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Job Failure Risk Analysis for sha: f15e4ed
|
/retest |
/override ci/prow/e2e-aws-ovn-ipsec-serial Known broken. |
@dgoodwin: Overrode contexts on behalf of dgoodwin: ci/prow/e2e-aws-ovn-ipsec-serial In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a reasonable foray into OLMv1 origin tests, but I do wonder if this will really stand the test of time.
I would somewhat assume that this would be quickly obviated by origin tests that actually exercise the APIs that we expect to exist.
var err error | ||
var raw string | ||
for _, ver := range api.version { | ||
raw, err = oc.AsAdmin().Run("get").Args("crds", fmt.Sprintf("%s.%s", api.plural, api.group), fmt.Sprintf("-o=jsonpath={.spec.versions[?(@.name==\"%s\")]}", ver)).Output() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: to avoid having to use escaped quotation marks
raw, err = oc.AsAdmin().Run("get").Args("crds", fmt.Sprintf("%s.%s", api.plural, api.group), fmt.Sprintf("-o=jsonpath={.spec.versions[?(@.name==\"%s\")]}", ver)).Output() | |
raw, err = oc.AsAdmin().Run("get").Args("crds", fmt.Sprintf("%s.%s", api.plural, api.group), fmt.Sprintf(`-o=jsonpath={.spec.versions[?(@.name==%q)]}`, ver)).Output() |
This is the initial test. Only works on tech-preview. Checks for presence of OLMv1 CRDs.