Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump RTE version to v0.19.0 #988

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shajmakh
Copy link
Member

Update dependency version to consume latest updates.

addresses: #978

Update dependency version to consume latest updates.

addresses: openshift-kni#978

Signed-off-by: Shereen Haj <[email protected]>
@openshift-ci openshift-ci bot requested review from ffromani and Tal-or August 20, 2024 12:53
Copy link
Contributor

openshift-ci bot commented Aug 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shajmakh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2024
@ffromani
Copy link
Member

ffromani commented Aug 20, 2024

this will require evaluating the transition to the new APIs (e.g. move to config files rather than the bunch of options we are using) and regression testing

example of how it could look like: k8stopologyawareschedwg/resource-topology-exporter#256

[EDIT] we can stay with the old-style commandline option and defer the transition to the configfile, but we should make a plan/timeline for the transition to configfile.

@shajmakh
Copy link
Member Author

/hold
for transitioning to configfiles style

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 22, 2024
@Tal-or
Copy link
Collaborator

Tal-or commented Aug 22, 2024

this will require evaluating the transition to the new APIs (e.g. move to config files rather than the bunch of options we are using) and regression testing

example of how it could look like: k8stopologyawareschedwg/resource-topology-exporter#256

[EDIT] we can stay with the old-style commandline option and defer the transition to the configfile, but we should make a plan/timeline for the transition to configfile.

I recommend to the take the opportunity of supporting NROP on HCP, and:

  1. bump dependent packages (deployer, RTE) to latest and greatest k8s and go versions.
  2. rebase kni-scheduler to latest commit on sig-scheduler.
  3. bump RTE, deployer and scheduler versions to latest and greatest on NROP.

@shajmakh
Copy link
Member Author

shajmakh commented Aug 22, 2024

this will require evaluating the transition to the new APIs (e.g. move to config files rather than the bunch of options we are using) and regression testing
example of how it could look like: k8stopologyawareschedwg/resource-topology-exporter#256
[EDIT] we can stay with the old-style commandline option and defer the transition to the configfile, but we should make a plan/timeline for the transition to configfile.

I recommend to the take the opportunity of supporting NROP on HCP, and:

  1. bump dependent packages (deployer, RTE) to latest and greatest k8s and go versions.
  2. rebase kni-scheduler to latest commit on sig-scheduler.
  3. bump RTE, deployer and scheduler versions to latest and greatest on NROP.

Thanks for sharing, good idea indeed for the 4.18 branch. I'll note that to apply it when we branch.

Copy link
Contributor

openshift-ci bot commented Sep 12, 2024

@shajmakh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-install-e2e 11af241 link true /test ci-install-e2e
ci/prow/ci-e2e 11af241 link true /test ci-e2e
ci/prow/images 11af241 link true /test images
ci/prow/ci-index 11af241 link true /test ci-index
ci/prow/ci-index-numaresources-operator-bundle 11af241 link true /test ci-index-numaresources-operator-bundle

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants