ibi mgmt: add deploy test suite #158
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @achuzhoy |
trewest
force-pushed
the
add-ibio-testcase
branch
from
ed9c881
to
c6cac5a
Compare
trewest
force-pushed
the
add-ibio-testcase
branch
from
c6cac5a
to
9f2f0f9
Compare
achuzhoy
reviewed
Aug 14, 2024
| By("Create baremetalhost for " + host) | ||
| hostBMH := bmh.NewBuilder( | ||
| APIClient, host, MGMTConfig.Cluster.Info.ClusterName, info.BMC.URLv4, host, info.BMC.MACAddress, "UEFI") | ||
| hostBMH.Definition.Spec.AutomatedCleaningMode = "disabled" |
There was a problem hiding this comment.
do we on purpose want to keep this one hardcoded?
There was a problem hiding this comment.
Yeah need to add it to eco-goinfra but this works for now
achuzhoy
reviewed
Aug 14, 2024
| MGMTConfig.Cluster.Info.ClusterName, MGMTConfig.Cluster.Info.ClusterName, | ||
| MGMTConfig.Cluster.Info.BaseDomain, MGMTConfig.Cluster.Info.ClusterName, metav1.LabelSelector{ | ||
| MatchLabels: map[string]string{ | ||
| "dummy": "label", |
achuzhoy
reviewed
Aug 14, 2024
| for hostname := range MGMTConfig.Cluster.Info.Hosts { | ||
| snoNodeName = hostname | ||
|
|
||
| break |
There was a problem hiding this comment.
Hmm, do we have to use loop (and break) here?
There was a problem hiding this comment.
It's just an easy way to get the SNO node's name until we support multinode
achuzhoy
reviewed
Aug 14, 2024
|
|
||
| return condition.Status == "True" && condition.Reason == ibiv1alpha1.InstallSucceededReason, nil | ||
|
|
||
| }).WithTimeout(time.Minute*20).WithPolling(time.Second*5).Should( |
There was a problem hiding this comment.
20 mins? this includes the installation of the spoke, right?
There was a problem hiding this comment.
This is for the full installation of the spoke, yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add first IBI connected deployment test case