update more operators for test #9
Conversation
| # If the result needs to be sent to DefectDojo, this must be a SARIF format file | ||
| results: "/tmp/oobtkube.sarif.json" # if None or "*stdout", the command's standard output is selected | ||
| # toolDir: scanners/generic/tools | ||
| #inline: "python3 oobtkube.py -d 120 -p <port> -i <ipaddr> -f /test/oobt_test_data/cr_example.yaml -o /tmp/oobtkube.sarif.json" |
There was a problem hiding this comment.
Please address these linter errors.
| ip_addresses = re.findall(r'10.64.\d+\.\d+', ip_output) | ||
|
|
||
| # Currently return the first IP address | ||
| # TODO: fix if there are multiple IP addresses and it causes an issue |
There was a problem hiding this comment.
I think that this error is relevant, perhaps its worth to fix it now.
obochan-rh
force-pushed
the
dast
branch
2 times, most recently
from
dcf045a
to
53b211c
Compare
| print(command) | ||
|
|
||
| process = subprocess.Popen(command, stdout=subprocess.PIPE, stderr=subprocess.PIPE, shell=True) | ||
| stdout, stderr = process.communicate() |
There was a problem hiding this comment.
I believe its better to print the stdout here, and check the errors.
|
This PR is approved just for testing, we agreed @obochan-rh to address all the relevant comments |
|
/lgtm |
There was a problem hiding this comment.
This PR is approved just for testing, we agreed @obochan-rh to address all the relevant comments and fixes once this is verified to be working.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: obochan-rh, shaior The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.