Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend): update orm entities #117

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(backend): update orm entities #117

wants to merge 4 commits into from

Conversation

stampaaaron
Copy link
Contributor

No description provided.

@stampaaaron stampaaaron linked an issue Oct 18, 2024 that may be closed by this pull request
Copy link

changeset-bot bot commented Oct 18, 2024

⚠️ No Changeset found

Latest commit: e09e79b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 60 lines in your changes missing coverage. Please review.

Project coverage is 19.69%. Comparing base (42651ab) to head (e09e79b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
apps/backend/src/entities/entry.entity.ts 0.00% 15 Missing ⚠️
apps/backend/src/entities/language.entity.ts 0.00% 10 Missing ⚠️
apps/backend/src/entities/carer.entity.ts 0.00% 9 Missing ⚠️
apps/backend/src/entities/entryLanguage.entity.ts 0.00% 8 Missing ⚠️
apps/backend/src/entities/participant.entity.ts 0.00% 6 Missing ⚠️
apps/backend/src/entities/questionnaire.entity.ts 0.00% 6 Missing ⚠️
apps/backend/src/entities/user.entity.ts 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
- Coverage   23.07%   19.69%   -3.38%     
==========================================
  Files          20       21       +1     
  Lines         169      198      +29     
  Branches        9        7       -2     
==========================================
  Hits           39       39              
- Misses        127      156      +29     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@openscript openscript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great initial work!

I suggest the following changes:

  • Update accordingly to the most recent ERD
  • Fix the typos
  • Add check constraints like mentioned in the ERD
  • Clean up the migration: It seems like it depends on a previous migration, that is now missing. The migration doesn't run on my device.

apps/backend/mikro-orm.config.ts Show resolved Hide resolved
apps/backend/src/entities/entry.entity.ts Show resolved Hide resolved
apps/backend/src/entities/entry.entity.ts Outdated Show resolved Hide resolved
apps/backend/src/entities/entryLanguage.entity.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plan database model
2 participants