fix: don't delete functions generated by other build plugins #2511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Package size report 0.04%↑
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
pieh
force-pushed
the
michalpiechowiak/frp-742-nextjs-runtime-deletes-functions-and-edge-functions
branch
3 times, most recently
from
d879ac2
to
9adcf47
Compare
pieh
force-pushed
the
michalpiechowiak/frp-742-nextjs-runtime-deletes-functions-and-edge-functions
branch
from
9adcf47
to
7195b1a
Compare
…tes-functions-and-edge-functions
…tes-functions-and-edge-functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are currently clearing out entire
.netlify/functions-internaland.netlify/edge-functionsto get rid of potentially stale functions generated by previous builds. We however also potentially delete functions generated by other build plugins / integrations making impossible to use other integrations with Next Runtime.The change in this PR make it so we don't clear entire directories - instead we look for metadata files and find functions generated by
@netlify/plugin-nextjsand selectively delete those while keeping other functions untouchedEDIT:
this is considered pretty risky change so this being draft tries to reflect that it shouldn't be merged without much considerations (probably better to figure out better alternative). #2536 reduced the reach of the problem for now, but it isn't completely solved yet
Tests
A test case added with fixture simulating stale next runtime functions as well as simulating other build plugin / integration
Relevant links (GitHub issues, etc.) or a picture of cute animal
Fixes https://linear.app/netlify/issue/FRP-742/nextjs-runtime-deletes-functions-and-edge-functions-generated-by-other