-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FM2-448: Add Unit Test for Servlets in SMART-on-FHIR #24
base: master
Are you sure you want to change the base?
Conversation
# Conflicts: # omod/src/main/java/org/openmrs/module/smartonfhir/web/filter/CORSFilter.java
Add Demo SMART App inside patient chart (openmrs#9)
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
=============================================
+ Coverage 8.03% 27.98% +19.94%
- Complexity 11 38 +27
=============================================
Files 24 24
Lines 498 504 +6
Branches 68 70 +2
=============================================
+ Hits 40 141 +101
+ Misses 457 351 -106
- Partials 1 12 +11
Continue to review full report at Codecov.
|
@ibacher PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@theanandankit Nice work! Some very small things to fix up. Do you think there's a way to refactor things so we're relying less on PowerMock?
omod/src/main/java/org/openmrs/module/smartonfhir/web/servlet/SmartLaunchOptionSelected.java
Outdated
Show resolved
Hide resolved
.../src/test/java/org.openmrs.module.smartonfhir/web/servlet/SmartLaunchOptionSelectedTest.java
Outdated
Show resolved
Hide resolved
c904834
to
1547912
Compare
@ibacher I tried to rely on Powermock less, but there is someplace where we have to use PowerMock, i.e. to Mock the Static Classes, use doReturn for Static Class functions. Could you please take a look? I also made all the changes you suggested. Thanks. |
@ibacher Changed the dependency from PowerMock to Mockito. PTAL |
@ibacher PTAL. |
Issue link: https://issues.openmrs.org/projects/FM2/issues/FM2-448?filter=allissues