Skip to content

Commit

Permalink
Add dependency on com.fasterxml.jackson.com; switch to version used b…
Browse files Browse the repository at this point in the history 
…y OpenMRS Core
  • Loading branch information
@mogoodrich
mogoodrich committed Jul 28, 2020
1 parent 5e0b93f commit 40c1b7d
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -279,15 +279,20 @@
</dependency>

<!-- For reading YAML and JSON files -->
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
<version>2.9.8</version>
</dependency>

This comment has been minimized.

Sign in to view

Copy link
@mogoodrich

mogoodrich Jul 28, 2020

Author Member

@mseaton this version is included in OpenMRS Core 2.3, but OpenMRS Core 2.2 includes an earlier version, which assumedly is why the tests failed. (Not sure why the tests against 2.1.x and earlier didn't fail).

Is it a problem to include this dependency although it's also being included by core?

(Tangentially, willl set up testing aginst 2.3)

This comment has been minimized.

Sign in to view

Copy link
@mogoodrich

mogoodrich Jul 28, 2020

Author Member

Oh, I see, there are some conditional dependencies in the various artifacts, will see if I can figure this out.
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
<version>2.10.1</version>
<version>2.9.8</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.dataformat</groupId>
<artifactId>jackson-dataformat-yaml</artifactId>
<version>2.10.1</version>
<version>2.9.8</version>
</dependency>

<dependency>
Expand Down

0 comments on commit 40c1b7d

Please sign in to comment.