(test) O3-3939: Add test to repeat component #385
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WodPachua
changed the title
WodPachua
changed the title
|
@WodPachua are you still working on this? |
|
Was trying to add another/more tests... had made the draft for your review if am on the right track |
samuelmale
reviewed
Sep 25, 2024
src/components/repeat/repeat.test.ts
Outdated
Comment on lines
30
to
36
| it('Should update field ID in expressions when adding repeated fields', () => { | ||
| const expression = "infantStatus !== 'someValue'"; | ||
| const fieldIds = ['birthDate', 'infantStatus', 'deathDate']; | ||
| const updatedExpression = updateFieldIdInExpression(expression, 2, fieldIds); | ||
|
|
||
| expect(updatedExpression).toEqual("infantStatus_2 !== 'someValue'"); | ||
| }); |
There was a problem hiding this comment.
@WodPachua I like the test but the scope of work begs for testing the repeat component itself and not just the helpers. You want to render a form with a "repeatable" field, and then test out things like:
- Asserting that clicking the "Add" button clones the field at origin
- Test out submission (Assert that both the origin and its instances' values are submitted successfully)
- Edit mode (Assert that a repeat field with instances is properly initialised (hydrated) as expected)
|
@WodPachua are you still working on this? |
|
|
Have already noted the changes proposed on slack |
|
@WodPachua you probably want to do something like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Added test to the repeat component in the form engine
Screenshots
Related Issue
O3-3939
Other