Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) O3-4135 - Disable help icon while user is logged out #1186

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

suubi-joshua
Copy link
Contributor

@suubi-joshua suubi-joshua commented Oct 28, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. Ensure your PR title includes a conventional commit label (such as feat, fix, or chore, among others). See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

The help icon (menu) appears even when the user is not logged In, I have made use of the useSession to check whether the user is authenticated or not then display the help icon.
The context of why am doing this is here

Screenshots

Screencast.from.28-10-24.16.19.09.webm

Related Issue

Other

@suubi-joshua
Copy link
Contributor Author

@denniskigen what are your thoughts on this.

Copy link

@WodPachua WodPachua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @suubi-joshua . Looks good to me...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants