Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure proper handling of pagination for Billable Services #68

Merged
merged 5 commits into from
Oct 29, 2024
Merged

Conversation

ODORA0
Copy link
Member

@ODORA0 ODORA0 commented Oct 25, 2024

Requirements

  • This PR has a title that briefly describes the work done including a conventional commit type prefix and a Jira ticket number if applicable. See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.

Summary

Screenshots

image

Related Issue

https://openmrs.atlassian.net/browse/O3-4102

Other

PS: The screenshot doesn't represent how the billable services table values are/appear, I created a function that creates a static mock dataset of 100 billable services

Also fixed failing tests causing the build to fail. The ...jest.requireActual('@openmrs/esm-framework') which was causing the circular dependency

});

xit('should render patient name as a link', async () => {
xtest('should render patient name as a link', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you comment this ?

Copy link
Contributor

@lucyjemutai lucyjemutai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good. the tests are passing on my local

@ODORA0 ODORA0 merged commit 264098c into main Oct 29, 2024
5 checks passed
@ODORA0 ODORA0 deleted the o3-4102 branch October 29, 2024 08:53
@WodPachua
Copy link
Contributor

WodPachua commented Oct 29, 2024

Thanks @ODORA0 for this... Tested this locally... works fine on my end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants