Ensure proper handling of pagination for Billable Services #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
src/bills-table/bills-table.test.tsx
Outdated
| }); | ||
|
|
||
| xit('should render patient name as a link', async () => { | ||
| xtest('should render patient name as a link', () => { |
There was a problem hiding this comment.
Why did you comment this ?
lucyjemutai
approved these changes
Oct 28, 2024
CynthiaKamau
approved these changes
Oct 29, 2024
|
Thanks @ODORA0 for this... Tested this locally... works fine on my end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
For changes to apps
If applicable
Summary
Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-4102
Other
PS: The screenshot doesn't represent how the billable services table values are/appear, I created a function that creates a static mock dataset of 100 billable services
Also fixed failing tests causing the build to fail. The
...jest.requireActual('@openmrs/esm-framework')which was causing the circular dependency