Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Fix adding a bill in the billing form workspace. #46

Merged
merged 2 commits into from
May 21, 2024

Conversation

hadijahkyampeire
Copy link
Contributor

Requirements

  • This PR has a title that briefly describes the work done including a conventional commit type prefix and a Jira ticket number if applicable. See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.

Summary

  • This updates the versions of openmrs-esm-framework and esm-common-lib , this was causing the billing form workspace to fail to load a patientUuid which was making saving a bill fail. This resulted from the recent changes about workspaces which were moved to the core framework

Screenshots

billing-form.mov

Related Issue

Copy link
Contributor

@CynthiaKamau CynthiaKamau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hadijahkyampeire , left a minor comment

package.json Outdated Show resolved Hide resolved
@ODORA0 ODORA0 merged commit a325590 into main May 21, 2024
5 checks passed
@ODORA0 ODORA0 deleted the hk-fix-billing-form-workspace branch May 21, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants