Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O3-2890 Add ability to edit bill line item #39

Merged
merged 1 commit into from
Apr 23, 2024
Merged

O3-2890 Add ability to edit bill line item #39

merged 1 commit into from
Apr 23, 2024

Conversation

CynthiaKamau
Copy link
Contributor

Requirements

  • This PR has a title that briefly describes the work done including a conventional commit type prefix and a Jira ticket number if applicable. See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.

Summary

O3-2890 Add ability to edit bill line item

Screenshots

Screen.Recording.2024-04-03.at.15.28.12.mov

Related Issue

Other

@jecihjoy
Copy link
Member

jecihjoy commented Apr 4, 2024

@CynthiaKamau thanks for looking into this, however I believe we would wish to control who can edit the bill, I believe the edit bill functionality would usually be done by the cashier, that said the cashiers are limited to interract with the patients bills only through the billing dashboard, with that in mind the edit functionality is better off placed in the cashier dasboard, also the cashier could be restricted to only edit the quantity and billables prices should entirely be managed from the billable services dashboard by admins

Generally the edit functionality could introduce some loopholes that we would wish to avoid hence I believe we should interrogate further the need for this functionality

@CynthiaKamau CynthiaKamau force-pushed the O3-2890 branch 2 times, most recently from 18a4307 to 1c506d5 Compare April 8, 2024 05:44
@CynthiaKamau
Copy link
Contributor Author

@CynthiaKamau thanks for looking into this, however I believe we would wish to control who can edit the bill, I believe the edit bill functionality would usually be done by the cashier, that said the cashiers are limited to interract with the patients bills only through the billing dashboard, with that in mind the edit functionality is better off placed in the cashier dasboard, also the cashier could be restricted to only edit the quantity and billables prices should entirely be managed from the billable services dashboard by admins

Generally the edit functionality could introduce some loopholes that we would wish to avoid hence I believe we should interrogate further the need for this functionality

Thanks @jecihjoy for the input, i have added a config for the functionality. In terms of permissions, the edit button is an extension and implementors can configure their preferred permissions through configs.

@jecihjoy
Copy link
Member

jecihjoy commented Apr 8, 2024

@CynthiaKamau thanks for looking into this, however I believe we would wish to control who can edit the bill, I believe the edit bill functionality would usually be done by the cashier, that said the cashiers are limited to interract with the patients bills only through the billing dashboard, with that in mind the edit functionality is better off placed in the cashier dasboard, also the cashier could be restricted to only edit the quantity and billables prices should entirely be managed from the billable services dashboard by admins
Generally the edit functionality could introduce some loopholes that we would wish to avoid hence I believe we should interrogate further the need for this functionality

Thanks @jecihjoy for the input, i have added a config for the functionality. In terms of permissions, the edit button is an extension and implementors can configure their preferred permissions through configs.

@CynthiaKamau that works, I've seen it also defaulted to false

Copy link
Member

@ODORA0 ODORA0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ODORA0 ODORA0 merged commit 6a32dbc into main Apr 23, 2024
5 checks passed
@ODORA0 ODORA0 deleted the O3-2890 branch April 23, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants