-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
O3-2890 Add ability to edit bill line item #39
Conversation
@CynthiaKamau thanks for looking into this, however I believe we would wish to control who can edit the bill, I believe the edit bill functionality would usually be done by the cashier, that said the cashiers are limited to interract with the patients bills only through the billing dashboard, with that in mind the edit functionality is better off placed in the cashier dasboard, also the cashier could be restricted to only edit the quantity and billables prices should entirely be managed from the billable services dashboard by admins Generally the edit functionality could introduce some loopholes that we would wish to avoid hence I believe we should interrogate further the need for this functionality |
18a4307
to
1c506d5
Compare
Thanks @jecihjoy for the input, i have added a config for the functionality. In terms of permissions, the edit button is an extension and implementors can configure their preferred permissions through configs. |
@CynthiaKamau that works, I've seen it also defaulted to false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Requirements
For changes to apps
If applicable
Summary
O3-2890 Add ability to edit bill line item
Screenshots
Screen.Recording.2024-04-03.at.15.28.12.mov
Related Issue
Other