(fix) O3-4101: Configure service types and billables to be used in billing app #853
Conversation
|
@ODORA0 here is the PR to fix the billables |
frontend/config-core_demo.json
Outdated
| "serviceTypes": { | ||
| "billableService": "0dfe7d9f-1dc9-4e68-b4cb-d19e1a006c54" | ||
| }, | ||
| "defaultCurrency": "UGX" |
There was a problem hiding this comment.
Is this supposed to be UG. The Pr looks good
There was a problem hiding this comment.
Oh I was just testing... we could use USD since its more neutral and universally used
|
|
||
| <!-- Temporary work around to add prices via liquibase, as we wait for for the billable service edit feature --> | ||
| <changeSet id="add_item_prices" author="wodpachua"> | ||
| <sql>SET foreign_key_checks = 0;</sql> |
There was a problem hiding this comment.
We do not recommend adding metadata via sql
We use https://github.com/mekomsolutions/openmrs-module-initializer#openmrs-initializer-module
There was a problem hiding this comment.
@dkayiwa Thanks Daniel, have made the change.
There was a problem hiding this comment.
I thought you would change your sql insertions into some sort of csv files. Just like you have done for the rest.
There was a problem hiding this comment.
@dkayiwa Yes, but prices are not a supported domain currently in initializer... because its data that changes, so it has to be added by the user via the UI or via such SQL instructions as I had done previously.
Thats why I had used the SQL insertations, since we don't have an edit mode to edit the services added via initializer and add prices to them. And we needed to demo here... so this was a temporary work around until the edit mode could be introduced, or a way to add support for prices
Requirements
For changes to apps
If applicable
Summary
Screenshots
Related Issue
ISSUE 03-4101