Update regex e-mail #331
Merged
Update regex e-mail #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow a dash in the domain name, e.g., `[email protected]`. Might want to use some e-mail parsing library for this instead, but this at least fixes this oversight.
josvandervelde
approved these changes
May 19, 2024
There was a problem hiding this comment.
This does allow some invalid email addresses, such as [email protected].
It is probably better to allow invalid addresses rather than disallowing valid addresses. So I'd approve it - hopefully we'll use an email-parsing lib indeed in the new code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow a dash in the domain name, e.g.,
[email protected]. Might want to use some e-mail parsing library for this instead, but this at least fixes this oversight.