feat(meter): filter meter events by data properties #736
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter ingested events by data properties
I came across #629 while looking for an issue to practice Go :) I decided to give it a Go (pun intended) and see what I can come up with and saw that you already had some FilterBy definitions.
This PR implements the EQ operation on event data for strings, and makes is so that events that don't match the Filter are not merged into the materialized view of the meter.
i.e.:
for input
the following meters
Partially fixes #629
Notes for reviewer
Before implementing any further, I wanted to check in with you, whether this Filter format is something you'd like to stick to and how deep you want to go with the supported types for filter values, what use cases are you aware of so far?
Checklist