feat: add db schema and types for Plan API #1788
Conversation
chrisgacsal
added
area/api
release-note/feature
chrisgacsal
force-pushed
the
feat/plan-api-types
branch
from
965b7b3
to
0f4093d
Compare
| } | ||
| } | ||
|
|
||
| func JSONStringValueScanner[T any]() field.ValueScannerFunc[T, *sql.NullString] { |
There was a problem hiding this comment.
I'd suggest to move this under pkg/framework
| // Equal is a relaxed version of StrictEqual where it is allowed to return true in case a subset of the attributes are equal. | ||
| // Typically, you want to use Equal to compare two instances of T where one or both missing some metadata which are | ||
| // not required for comparison. Like comparing two instances of T before and after stored in data layer which assigns | ||
| // additional metadata like timestamps, unique identifiers, etc. | ||
| Equal(T) bool |
There was a problem hiding this comment.
just an opinion, but I'm not sure I'm sold on this... if this behaves differently case-by-case then IMO it should be a different thing altogether
There was a problem hiding this comment.
I'll remove it for now and we can discuss it separately. This is not required for this PR.
chrisgacsal
force-pushed
the
feat/plan-api-types
branch
from
0f4093d
to
48e7282
Compare
| } | ||
|
|
||
| func (Plan) Mixin() []ent.Mixin { | ||
| return []ent.Mixin{ |
There was a problem hiding this comment.
we have the UniqueResourceMixin to combine these:
| Default("USD"). | ||
| NotEmpty(). | ||
| Immutable(), | ||
| field.Time("effectiveFrom"). |
There was a problem hiding this comment.
we usually use underscore to define ent schema
There was a problem hiding this comment.
Agreed. Copy/paste error. Will fix it now.
|
|
||
| func (PlanPhase) Mixin() []ent.Mixin { | ||
| return []ent.Mixin{ | ||
| entutils.IDMixin{}, |
| Optional(). | ||
| Nillable(), | ||
| field.String("discounts"). | ||
| GoType([]plan.Discount{}). |
There was a problem hiding this comment.
normalize please, separate PR is ok
There was a problem hiding this comment.
Hmm. Why do we need the discounts to be normalized here?
There was a problem hiding this comment.
@hekike please discuss with @tothandras, the two of you are on a different stance regarding normalization so IMO lets come up with an agreement (came up on other PRs as well)
|
|
||
| func (PlanRateCard) Mixin() []ent.Mixin { | ||
| return []ent.Mixin{ | ||
| entutils.IDMixin{}, |
| field.String("description"). | ||
| Optional(). | ||
| Nillable(), | ||
| field.String("feature_key"). |
There was a problem hiding this comment.
these are mutable because user can edit plan in draft, right?
There was a problem hiding this comment.
Yup, thats the idea.
chrisgacsal
force-pushed
the
feat/plan-api-types
branch
from
48e7282
to
7b2a254
Compare
chrisgacsal
force-pushed
the
feat/plan-api-types
branch
2 times, most recently
from
7ad710b
to
a7bc011
Compare
chrisgacsal
force-pushed
the
feat/plan-api-types
branch
from
a7bc011
to
2e1a0a5
Compare
chrisgacsal
force-pushed
the
feat/plan-api-types
branch
from
2e1a0a5
to
a71553c
Compare
Overview