fix(client): fix array query param serialization in Node.js SDK

openmeterio · Jan 17, 2024 · 7f9b6b3 · 7f9b6b3
1 parent 327b6ba
commit 7f9b6b3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/api/client/node/clients/client.ts b/api/client/node/clients/client.ts
@@ -138,7 +138,9 @@ export class BaseClient {
       }
 
       if (Array.isArray(value)) {
-        searchParams.append(key, value.join(','))
+        for (const item of value) {
+          searchParams.append(key, item)
+        }
       } else if (value instanceof Date) {
         searchParams.append(key, value.toISOString())
       } else {

diff --git a/api/client/node/test/agent.ts b/api/client/node/test/agent.ts
@@ -131,7 +131,7 @@ client
     path: `/api/v1/meters/${mockMeter.slug}/query`,
     query: {
       subject: 'user-1',
-      groupBy: 'a,b',
+      groupBy: ['a', 'b'],
       from: new Date('2021-01-01').toISOString(),
       to: new Date('2021-01-02').toISOString(),
       windowSize: 'HOUR',