Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for issue #3158 - Streamline use of CompositeSurface with SurfaceFilter #3167
base: develop
Are you sure you want to change the base?
Fix for issue #3158 - Streamline use of CompositeSurface with SurfaceFilter #3167
Changes from 1 commit
f07974e
e4c0ee8
c418c32
9f03bcc
f0cee3a
a7fa568
7c8df81
906763d
7d2e116
066f2a4
f37d7d9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think better yet we'd be able to pass a
CompositeSurface
directly to theSurfaceFilter
class, which might require some additional handling in that object.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think it is clearer. It is already done. I thought it was easier to change the
SurfaceFilter
class than to make aCompositeSurface
always return a list of surfaces. Let me know what you think.