XML read fixes in Plot classes #2623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Funnily enough, it's probably my fault this broke after refactoring this a little for the ol' projection plots PR. |
gridley
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed recently while generating a voxel plot that when I tried to read back a model with
Model.from_xmlthat included a voxel plot, it raised an exception because it was expecting the "basis" to be set (which isn't written for a voxel plot). This PR fixes that and several other small bugs I noticed in XML read/write for Plots.Cue @gridley telling us how much this manual XML reading/writing sucks!
Checklist
I have run clang-format on any C++ source files (if applicable)