Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding bounding box to spherical mesh #2605

Closed
wants to merge 5 commits into from
Closed

Adding bounding box to spherical mesh #2605

wants to merge 5 commits into from

Conversation

caderache2014
Copy link
Contributor

Description

Adapted computation of lower_left and upper_right coordinates for spherical mesh objects. Tested against BoundingBox class

Fixes # 2550

  • I have performed a self-review of my own code
  • I have run clang-format on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@caderache2014
Copy link
Contributor Author

@shimwell I think something went awry with this pull request. I don't see any of the changes we made to the SphericalMesh class. No wonder the CI test is failing. There is no bounding_box property in this version of SphericalMesh. I'm trying to reconstruct the changes. I'll submit a new pull request

@Property
def bounding_box(self):
return openmc.BoundingBox(
np.array(self.origin[0] - self.r_grid, self.origin[1] - self.r_grid, self.origin[2] - self.r_grid),
np.array(self.origin[0] + self.r_grid, self.origin[1] + self.r_grid, self.origin[2] + self.r_grid)
)

@caderache2014 caderache2014 mentioned this pull request Jul 23, 2023
5 tasks
@shimwell
Copy link
Member

thanks for following this up @caderache2014

closing this PR in favor of #2620

@shimwell shimwell closed this Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants