-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable annotating contributor roles #75
Conversation
@tarleb this one is also ready for a first review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super neat, thank you! I added a few inline comments.
for _, roleDict in ipairs(author.roles) do | ||
role = roleDict.type[1].text | ||
if invalidRole(role) then | ||
error("invalid role for author " .. author.name .. ": " .. role) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how errors are handled by editorial-bot. @xuanxu, what happens if the conversion fails, would the authors see this error message?
76604f4
to
e7d5fe3
Compare
e7d5fe3
to
8622e3e
Compare
closing this one in favor of #87 |
Closes #73
This PR enables annotating author roles using the Contribution Role Taxonomy (CRediT). It also enables (optionally) annotating the contribution degree, as suggested by JATS.
It does the following:
default.latex
(after reference list)preprint.latex
(after reference list)Demo
Here's what this looks like at the end of the main PDF build:
Future Work
Future work for future PRs: