Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct nullability annotations in OIDEndSessionRequest #702

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Source/AppAuthCore/OIDEndSessionRequest.h
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@ NS_ASSUME_NONNULL_BEGIN
*/
- (instancetype)
initWithConfiguration:(OIDServiceConfiguration *)configuration
idTokenHint:(NSString *)idTokenHint
postLogoutRedirectURL:(NSURL *)postLogoutRedirectURL
idTokenHint:(nullable NSString *)idTokenHint
postLogoutRedirectURL:(nullable NSURL *)postLogoutRedirectURL
additionalParameters:(nullable NSDictionary<NSString *, NSString *> *)additionalParameters;

/*! @brief Designated initializer.
Expand All @@ -89,9 +89,9 @@ NS_ASSUME_NONNULL_BEGIN
*/
- (instancetype)
initWithConfiguration:(OIDServiceConfiguration *)configuration
idTokenHint:(NSString *)idTokenHint
postLogoutRedirectURL:(NSURL *)postLogoutRedirectURL
state:(NSString *)state
idTokenHint:(nullable NSString *)idTokenHint
postLogoutRedirectURL:(nullable NSURL *)postLogoutRedirectURL
state:(nullable NSString *)state
additionalParameters:(nullable NSDictionary<NSString *, NSString *> *)additionalParameters
NS_DESIGNATED_INITIALIZER;

Expand Down
10 changes: 5 additions & 5 deletions Source/AppAuthCore/OIDEndSessionRequest.m
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,9 @@ - (instancetype)init
)

- (instancetype)initWithConfiguration:(OIDServiceConfiguration *)configuration
idTokenHint:(NSString *)idTokenHint
postLogoutRedirectURL:(NSURL *)postLogoutRedirectURL
state:(NSString *)state
idTokenHint:(nullable NSString *)idTokenHint
postLogoutRedirectURL:(nullable NSURL *)postLogoutRedirectURL
state:(nullable NSString *)state
additionalParameters:(NSDictionary<NSString *,NSString *> *)additionalParameters
{
self = [super init];
Expand All @@ -82,8 +82,8 @@ - (instancetype)initWithConfiguration:(OIDServiceConfiguration *)configuration
}

- (instancetype)initWithConfiguration:(OIDServiceConfiguration *)configuration
idTokenHint:(NSString *)idTokenHint
postLogoutRedirectURL:(NSURL *)postLogoutRedirectURL
idTokenHint:(nullable NSString *)idTokenHint
postLogoutRedirectURL:(nullable NSURL *)postLogoutRedirectURL
additionalParameters:(NSDictionary<NSString *,NSString *> *)additionalParameters
{
return [self initWithConfiguration:configuration
Expand Down