add unit test for fall backup to default logic

openhydra · Jul 18, 2024 · de7a686 · de7a686
1 parent 924da79
commit de7a686
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 14 deletions.
diff --git a/pkg/open-hydra/handler.go b/pkg/open-hydra/handler.go
@@ -150,7 +150,7 @@ func (builder *OpenHydraRouteBuilder) GetServerConfigFromConfigMap() (*config.Op
  return nil, fmt.Errorf("config map data is empty")
  }
 
- serverConfig := &config.OpenHydraServerConfig{}
+ serverConfig := config.DefaultConfig()
 
  err = yaml.Unmarshal([]byte(configMap.Data["config.yaml"]), serverConfig)
  if err != nil {

diff --git a/pkg/open-hydra/k8s/k8s.go b/pkg/open-hydra/k8s/k8s.go
@@ -2,7 +2,6 @@ package k8s
 
 import (
  "context"
- "encoding/json"
  "fmt"
  "log/slog"
  "open-hydra/pkg/open-hydra/apis"
@@ -181,17 +180,7 @@ func (help *DefaultHelper) CreateDeployment(deployParameter *DeploymentParameter
 
  deployment.Spec.Template.Spec.Affinity = deployParameter.Affinity
 
- debugDeploy, err := json.Marshal(deployment)
- if err != nil {
- slog.Error("failed to marshal deployment", "error", err)
- return err
- }
-
- fmt.Println("~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~`")
- slog.Info("deployment", "deployment", string(debugDeploy))
- fmt.Println("~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~`")
-
- _, err = deployParameter.Client.AppsV1().Deployments(deployParameter.Namespace).Create(context.TODO(), deployment, metaV1.CreateOptions{})
+ _, err := deployParameter.Client.AppsV1().Deployments(deployParameter.Namespace).Create(context.TODO(), deployment, metaV1.CreateOptions{})
  if err != nil {
  return err
  }

diff --git a/pkg/open-hydra/open-hydra_test.go b/pkg/open-hydra/open-hydra_test.go
@@ -124,9 +124,14 @@ var _ = Describe("open-hydra-server handler test", func() {
 
  Describe("GetServerConfigFromConfigMap test", func() {
  It("get server config from config map should be expected", func() {
+ fakeK8sHelper.ServerConfig.PodAllocatableLimit = 0
  config, err := builder.GetServerConfigFromConfigMap()
  Expect(err).To(BeNil())
- Expect(config).To(Equal(fakeK8sHelper.ServerConfig))
+ Expect(int(config.PodAllocatableLimit)).To(Equal(-1))
+ fakeK8sHelper.ServerConfig.PodAllocatableLimit = 100
+ config, err = builder.GetServerConfigFromConfigMap()
+ Expect(err).To(BeNil())
+ Expect(int(config.PodAllocatableLimit)).To(Equal(100))
  })
  })