feat(navbar): align navbars to design system #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orbitalsqwib
force-pushed
the
feat/design-system/navbar
branch
2 times, most recently
from
b4551c1
to
9efa1ab
Compare
- implement common navbar components such as the navbar container, back-button and tabs - implement theme styles for common navbar components aligned to the design system
- implement common navbar component styles for buttons - use common navbar components - simplify layout - update styles to align with design system
- use common navbar components - simplify layout - update styles to align with design system
- use common navbar components - simplify layout - update styles to align with design system
- use common navbar components - simplify layout - update styles to align with design system - extract styles to separate theme file
lamkeewei
force-pushed
the
feat/design-system/navbar
branch
from
9efa1ab
to
0fea303
Compare
orbitalsqwib
commented
Jun 16, 2021
|
Note that this should also partially solve #393 |
orbitalsqwib
force-pushed
the
feat/design-system/navbar
branch
from
0fea303
to
3edfd4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Align navbars to the design system via custom components.
Closes #548
Solution
Features:
Improvements:
Before & After Screenshots
BEFORE:
AFTER:
Tests