feat/arity - refactor to allow for variable number of arguments #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous `prepublish` command was deprecated and no longer runs before `npm publish` is executed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the number of arguments of a function or method is fixed, as the AST is inflexible about the number of arguments that can be accepted in a function call.
This inhibits further language development as sometimes we would prefer to have an optional number of arguments.
For example, in #10 we do not have the option of providing the function
UNIDECODE(string, [code_point_start, code_point_end]), as the number of arguments would have to be fixed as either 1 or 3, but not both,.Solution
Move the valid arguments check into
PlumberCallable'sarityfunction, by refactoring it's type signature toarity(argsLength: number): boolean.Tests
As we already have tests for global functions, this PR extends the coverage to include methods and inheritance, so as to ensure that no functionality has been broken.