⬆️(project) upgrade cypress to version 10.11.0 #23
Conversation
When bootstraping this project in the dev branch two additional directories are created: edx/src and edx/modules. To ease switching between a feature branch and the dev branch we choose to ignore the edx/modules directory.
When bootstraping this project in the dev branch two additional directories are created: edx/src and edx/modules. To ease switching between a feature branch and the dev branch we choose to make the linter ignore the edx directory.
To keep the circleci machine up to date.
| - run: | ||
| name: Run e2e tests | ||
| command: make run-edx test | ||
| command: make test |
There was a problem hiding this comment.
To ensure edx is running, what about the following instead (along with removing the run-edx target in the previous step)?
| command: make test | |
| command: make run-edx && make test |
| @@ -12,14 +12,20 @@ describe("LMS JS Input Response Problem Interaction Test", () => { | |||
| cy.lmsEnroll(true); | |||
| // Navigate to the courseware. | |||
| cy.visit(sectionUrl); | |||
| // Wait for iframe to become interactive. | |||
| // eslint-disable-next-line cypress/no-unnecessary-waiting | |||
| cy.wait(1500); | |||
There was a problem hiding this comment.
If there is no better way than enforcing this wait phase, please explain why?
There was a problem hiding this comment.
You are right) There is a better way!
The challenge was that the js-input-problem is in a cross-origin iframe (hosted at https://studio.edx.org/c4x/edX/DemoX/asset/webGLDemo.html), and browsers do not allow JavaScript from one domain to access elements in another domain for security reasons. Luckily Cypress allows us to disable browser security. Updated this part here. However, unfortunately, this only works for chrome-based browsers.
The iframe in the js_input_response test needs some time to become interactive. Therefore we disable chromeWebSecurity to give cypress access to the cross-domain iframe to check whether the iframe is ready or not.
The drag_and_drop test relies on the problem beeing at it's initial state. However, edX preserves the state of the problem once it's submitted. Therefore we reset the drag_and_drop problem before answering it.
We upgrade cypress to its latest version. We also upgrade the javascript dependencies used for linting.
SergioSim
force-pushed
the
upgrade-cypress-10
branch
from
4d4b309
to
202af12
Compare
Purpose
We want our project to be up to date with the latest cypress release.
Proposal
package.json/yarn.lockIncludes changes from #22. Blocked until is #22 merged.