-
-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Goodbye little Data Importer 👋 #4781
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @g123k!
Looks good to me, except something with go_router where you don't set the language anymore, and it does look suspicious. Any explanation?
ProductQuery.setLanguage(context, userPreferences); | ||
context.read<ProductPreferences>().refresh(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't see the relationship with the current PR. We need a language, right, regardless of data migration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops I didn't see your comment.
The reason is just above:
// The migration requires the language to be set in the app!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The migration requires the language to be set in the app!
So does the app, so I hope that setLanguage in migration was redundant with a setLanguage in the app and that indeed we can get rid of setLanguage/migration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, I've checked 1 year and a half ago and the code was placed elsewhere.
I will move the code.
Ok, for the migrations of the legacy Open Beauty Facts (Android, iOS), Pet Food (Android) and Products (Android), we'll do something rash, I believe. |
Actually, if we go for a single app, there is no migration possible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me
I have to move some code and re-test everything. |
I have re-tested everything and it's OK. |
You served many users well |
Hi everyone!
Now that 99% of the user base has migrated to the Flutter app, we can remove the process of migrating lists from old apps (Android/iOS).
In this PR, this is essentially a giant
git rm
.I have checked the app works on Android/iOS/macOS with a clean installation and an already existing one.
So for me, it's time to say goodbye to this code.
On iOS, I think reduce a lot the size, as Realm is a big dependency.