Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update openfisca-core to 42.0.0 #302

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Conversation

bonjourmauko
Copy link
Member

Depends on openfisca/openfisca-core#1223
Depends on openfisca/country-template#154

  • Minor change.
    • Update OpenFisca-Core to 42.0.0

These changes:

  • Change non-functional parts of this repository (for instance editing the README)

@bonjourmauko bonjourmauko self-assigned this Sep 26, 2024
@bonjourmauko bonjourmauko added the dependencies Pull requests that update a dependency file label Sep 26, 2024
Copy link
Contributor

@benoit-cty benoit-cty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mauko, just a warning about using url in dependency, but maybe it was just for testing ?

setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
Copy link
Member

@benjello benjello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge only after openfisca-core have been tested against france tests

@bonjourmauko
Copy link
Member Author

@benjello @benoit-cty As with France, this PR can't be merged as is. The other PRs need to be merged first, then I'll update to the correct PyPi package here.

@bonjourmauko bonjourmauko changed the title chore: update openfisca-core to 42.0.0 build: update openfisca-core to 42.0.0 Sep 30, 2024
@bonjourmauko
Copy link
Member Author

@benjello @benoit-cty I let you merge this one? As I'm not a maintainer of this repo.

@benjello
Copy link
Member

@benoit-cty @clallemand @sylvainipp @Lolajossipp: I would merge this PR. Unless you are in the middle of delicate work and it could be harmful to you. I can also ask for a major version change. But keeping a minor change would allow bugs to appear that would force us to test this package better to avoid this kind of problems next time. Thanks for your feedback!

@sylvainipp
Copy link
Contributor

I'm OK to merge. The CI tests can't pass because of the wrong import of Core, so the sooner the better from my point of view.

@benjello
Copy link
Member

@benoit-cty can you approve the changes now ?

@clallemand
Copy link
Contributor

@benjello Can I test this PR in our repos today before you merge it ? Just to be shure its a patch bump version

@benjello
Copy link
Member

Sure @clallemand

@clallemand
Copy link
Contributor

@benjello @benoit-cty I've changed my mind. I can't test it because of openfisca-france, but you can merge it not to block @sylvainipp 's work on this repo

Copy link
Contributor

@benoit-cty benoit-cty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a typo with a double indentation. Beside that I'm OK. Thanks @bonjourmauko !

Makefile Outdated Show resolved Hide resolved
Co-authored-by: Benoit Courty <[email protected]>
@benjello benjello merged commit fdeef04 into master Oct 16, 2024
10 checks passed
@benjello benjello deleted the chore/update-core-42.0.0 branch October 16, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants