Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IsObject(null) returns null, not false #179

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

elenaparaschiv
Copy link

Problem:
The function isObject should return true or false, depending if the supplied parameter is a true object, but if we call it with null it will return null

isObject(null)
//returns null

Solution:
If we wrap the value inside !! we avoid this edge case, ensuring false will be returned if the parameter is null

isObject(null);
// returns false

__Problem:__
The function isObject should return true or false, depending if the supplied parameter is a true object, but if we call it with null it will return null
```
isObject(null)
//returns null
```
__Solution:__
If we wrap the value inside !! we avoid this edge case, ensuring false will be returned if the parameter is null
``` 
isObject(null);
// returns false
````
@asutosh97
Copy link

Rightly pointed out. I was also going through the codebase and figured it out now. Thought of making a PR, but saw yours. Good job 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants