fix: fix sorting tags on MySQL

openedx · Oct 20, 2023 · ee6d554 · ee6d554
1 parent 868f3b8
commit ee6d554
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/openedx_tagging/core/tagging/models/base.py b/openedx_tagging/core/tagging/models/base.py
@@ -466,10 +466,11 @@ def _get_filtered_tags_deep(
             # For a root tag, we want sort_key="RootValue" and for a depth=1 tag
             # we want sort_key="RootValue\tValue". The following does that, since
             # ConcatNull(...) returns NULL if any argument is NULL.
-            Coalesce(ConcatNull(F("parent__parent__parent__value"), Value("\t")), Value("")),
-            Coalesce(ConcatNull(F("parent__parent__value"), Value("\t")), Value("")),
-            Coalesce(ConcatNull(F("parent__value"), Value("\t")), Value("")),
+            ConcatNull(F("parent__parent__parent__value"), Value("\t")),
+            ConcatNull(F("parent__parent__value"), Value("\t")),
+            ConcatNull(F("parent__value"), Value("\t")),
             F("value"),
+            Value("\t"),  # We also need the '\t' separator character at the end, or MySQL will sort things wrong
             output_field=models.CharField(),
         ))
         # Add the parent value