Skip to content

Commit

Permalink
refactor: add typings
Browse files Browse the repository at this point in the history
  • Loading branch information
rpenido committed Oct 12, 2023
1 parent d54fb3a commit d85ee7f
Showing 1 changed file with 11 additions and 5 deletions.
16 changes: 11 additions & 5 deletions openedx_tagging/core/tagging/rest_api/v1/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -253,14 +253,17 @@ def get_queryset(self) -> models.QuerySet:
object_id=object_id,
)

if not self.request.user.has_perm(perm, perm_obj):
if not self.request.user.has_perm(
perm,
perm_obj, # type: ignore[arg-type]
):
raise PermissionDenied(
"You do not have permission to view object tags for this taxonomy or object_id."
)

return get_object_tags(object_id, taxonomy_id)

def retrieve(self, request, *args, **kwargs):
def retrieve(self, request, *args, **kwargs) -> Response:
"""
Retrieve ObjectTags that belong to a given object_id
Expand All @@ -275,7 +278,7 @@ def retrieve(self, request, *args, **kwargs):
serializer = ObjectTagSerializer(object_tags, many=True)
return Response(serializer.data)

def update(self, request, *args, **kwargs):
def update(self, request, *args, **kwargs) -> Response:
"""
Update ObjectTags that belong to a given object_id
Expand Down Expand Up @@ -311,15 +314,18 @@ def update(self, request, *args, **kwargs):
taxonomy = query_params.validated_data.get("taxonomy", None)
taxonomy = taxonomy.cast()

perm = f"{taxonomy._meta.app_label}.change_objecttag"
perm = "oel_tagging.change_objecttag"

object_id = kwargs.pop('object_id')
perm_obj = ObjectTagPermissionItem(
taxonomy=taxonomy,
object_id=object_id,
)

if not request.user.has_perm(perm, perm_obj):
if not request.user.has_perm(
perm,
perm_obj, # type: ignore[arg-type]
):
raise PermissionDenied(
"You do not have permission to change object tags for this taxonomy or object_id."
)
Expand Down

0 comments on commit d85ee7f

Please sign in to comment.