Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Upgrade to Node 20 #734

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

BilalQamar95
Copy link
Contributor

Description

  • Regenerated package-lock.json with node v20 and NPM 10.
  • Updated .nvmrc to v20
  • Updated the lockfile version check workflow

Second step in the Node 20 upgrade process, See the tracking issue for further information.

@BilalQamar95 BilalQamar95 self-assigned this Sep 18, 2024
@BilalQamar95 BilalQamar95 mentioned this pull request Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.41%. Comparing base (bff992a) to head (b2158b0).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #734   +/-   ##
=======================================
  Coverage   83.41%   83.41%           
=======================================
  Files          40       40           
  Lines        1073     1073           
  Branches      197      197           
=======================================
  Hits          895      895           
  Misses        166      166           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brian-smith-tcril brian-smith-tcril merged commit dd36b46 into master Sep 19, 2024
7 checks passed
@brian-smith-tcril brian-smith-tcril deleted the bilalqamar95/node20-upgrade-2 branch September 19, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants