Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(CourseCardImage.jsx): img width change to w-100 for safari browser #461

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bayirdan
Copy link

Fixed img width to w-100 for Safari browser

before:
img-safari

after:
img-safari-fix

@bayirdan bayirdan requested a review from a team as a code owner September 18, 2024 11:01
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 18, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @bayirdan!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Submit a signed contributor agreement (CLA)

⚠️ We ask all contributors to the Open edX project to submit a signed contributor agreement or indicate their institutional affiliation.
Please see the CONTRIBUTING file for more information.

If you've signed an agreement in the past, you may need to re-sign.
See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed.
After this time, you can re-run the CLA check by adding a comment below that you have signed it.
If the CLA check continues to fail, you can tag the @openedx/cla-problems team in a comment for further assistance.

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @2U-aperture. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@MaxFrank13 MaxFrank13 added the needs maintainer attention Issue or PR specifically needs the attention of the maintainer. label Sep 19, 2024
@itsjeyd
Copy link

itsjeyd commented Sep 20, 2024

Hey @bayirdan, thank you for this contribution!

As the bot says, you'll need to submit a signed CLA. Without that we won't be able to merge your change.

And it looks like some tests are failing here. Could you please have a look at those?

@MaxFrank13 MaxFrank13 added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs maintainer attention Issue or PR specifically needs the attention of the maintainer. labels Sep 20, 2024
@itsjeyd
Copy link

itsjeyd commented Oct 17, 2024

Hey @bayirdan, just checking in to see if you're still planning to continue working on this PR?

@itsjeyd itsjeyd added the inactive PR author has been unresponsive for several months label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inactive PR author has been unresponsive for several months open-source-contribution PR author is not from Axim or 2U waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc.
Projects
Status: Blocked
Status: Needs Tests Run or CLA Signed
Development

Successfully merging this pull request may close these issues.

4 participants