-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Remove support for Node 18 #436
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #436 +/- ##
=======================================
Coverage 97.24% 97.24%
=======================================
Files 154 154
Lines 1378 1378
Branches 229 228 -1
=======================================
Hits 1340 1340
Misses 36 36
Partials 2 2 ☔ View full report in Codecov by Sentry. |
I'm not formally blocking this because the constraint is 2U-only, but Aperture won't be progressing this until the work to enable deploying node 20 in our environment is complete. |
@BilalQamar95 I just learned that there was a decision to hold off on removing Node 18 support until after the Sumac cut. Once Sumac is cut, then these PRs to remove Node 18 support can be merged. |
didn't see the conflict before I accepted the changes, d'oh, then I saw jason's message too (double d'oh)
Note: As per openedx/public-engineering#280 this can merge after Sumac cut.
Description
Completed upgrade to Node 20 by removing the Node 18 CI check and using
.nvmrc
for version to use.See the tracking issue for further information.